Ticket #3954 (closed Feature Requests: wontfix)

Opened 2 years ago

Last modified 2 years ago

keyword update in asterisk 1.6 sip, canreinvite becomes directmedia

Reported by: john@erba.tv Assigned to: p_lindheimer
Priority: minor Milestone: 2.8
Component: Core Version: 2.6-branch
Keywords: sip syntax changes Cc:
Confirmation: Unreviewed SVN Revision (if applicable):
Backend Engine: Asterisk 1.6 Backend Engine Version: 1.6.2

Description

In asterisk 1.6.2 the canreinvite keyword becomes directmedia. (see upgrade.txt and the samples file in asterisk configs directory). Both work at the moment.

I would have done a patch for this with the usual mechanism to check asterisk versions, but the problem is that asterisk version is not available inside the function core_devices_configpageinit of file admin/modules/core/functions.inc.php. If I add it as a "global $version;" there is no value. How should the issue of version conditional keywords be addressed inside core_devices_configpageinit function?

I'll attach the current version of the patch in which I had to force the value to my asterisk version, so that it's clear what the problem is.

I also attach the sql to update the existing db sip entries.

sipsettings modules will also require updating.

Attachments

canreinvite-patch.txt (2.5 kB) - added by john@erba.tv on 11/22/09 03:43:28.
incomplete patch
canreinvite-patch.2.txt (2.5 kB) - added by john@erba.tv on 11/22/09 03:44:25.
incomplete patch
canreinvite-sql.txt (312 bytes) - added by john@erba.tv on 11/22/09 03:46:22.
sql to change canreinvite keyword to directmedia and delete canreinvite if both are present

Change History

11/22/09 03:43:28 changed by john@erba.tv

  • attachment canreinvite-patch.txt added.

incomplete patch

11/22/09 03:44:25 changed by john@erba.tv

  • attachment canreinvite-patch.2.txt added.

incomplete patch

11/22/09 03:46:22 changed by john@erba.tv

  • attachment canreinvite-sql.txt added.

sql to change canreinvite keyword to directmedia and delete canreinvite if both are present

11/22/09 04:59:09 changed by mickecarlsson

  • milestone changed from 2.6 to 2.7.

I will put this in 2.7 as it is still to early to do changes in FreePBX for Asterisk 1.6.2, and the canreinvite is still there to be backward compatible.

This is from the UPPGRADE.txt:

The 'canreinvite' option support by the SIP, MGCP and Skinny channel drivers has been renamed to 'directmedia', to better reflect what it actually does. In the case of SIP, there are still re-INVITEs issued for T.38 negotiation, starting and stopping music-on-hold, and other reasons, and the 'canreinvite' option never had any effect on these cases, it only affected the re-INVITEs used for direct media path setup. For MGCP and Skinny, the option was poorly named because those protocols don't even use INVITE messages at all. For backwards compatibility, the old option is still supported in both normal and Realtime configuration files, but all of the sample configuration files, Realtime/LDAP schemas, and other documentation refer to it using the new name.

02/17/10 00:22:42 changed by p_lindheimer

  • milestone changed from 2.7 to 2.8.

we'll address this next time like for 1.8 since it still works fine

02/28/10 09:59:25 changed by p_lindheimer

  • milestone changed from Cut Line to 2.8.

03/17/10 00:52:59 changed by p_lindheimer

  • type changed from Patches to Feature Requests.

05/20/10 19:25:32 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to wontfix.

given this is not even being deprecated but simply 'renamed' and given the name change was more because of Skinny and MGCP (form the comments) I am going to close this as wontfix and we will continue to use canreinvite until there is a good reason presented to change it.

Here is the code in 1.6.2: 

  } else if (!strcasecmp(v->name, "directmedia") || !strcasecmp(v->name, "canreinvite")) {

So it is not even 'deprecated' at this point, When that happens, we can revisit this.